lkml.org 
[lkml]   [2016]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Staging: android: ion: fixes use of typedef
On Sat, May 07, 2016 at 03:22:03PM -0500, Thimo Braker wrote:
> Fixes a checkpatch.pl warning about 'do not add new typedefs'
>
> Signed-off-by: Thimo Braker <thibmorozier@gmail.com>
> ---
> drivers/staging/android/uapi/ion.h | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 0a8e40f..77a46f0 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -20,8 +20,6 @@
> #include <linux/ioctl.h>
> #include <linux/types.h>
>
> -typedef int ion_user_handle_t;
> -

You just broke userspace :(

Sorry, you can't do this, be careful when touching files that cross the
user/kernel boundry (hint, they have uapi in the path), you have to know
exactly what you are doing when you do that.

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-05-08 05:01    [W:0.037 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site