Messages in this thread | | | Date | Fri, 6 May 2016 15:54:59 -0400 | From | Greg KH <> | Subject | Re: [PATCH 0/1] devpts: Removing the need for pt_chown |
| |
On Fri, May 06, 2016 at 12:45:01PM -0700, Peter Hurley wrote: > On 05/06/2016 12:35 PM, Greg KH wrote: > > On Fri, May 06, 2016 at 02:04:12PM -0500, Eric W. Biederman wrote: > >> > >> Greg, > >> > >> Could you please apply the following patch to tty-next so it can be > >> merged into 4.7-rc1. > >> > >> We have had a long series of discussions and in the last iteration we > >> finally converged on a set of semantics that does not break userspace > >> and also makes the code simpler. > > > > Did everyone agree? I didn't think so, but the thread got long and > > messy. And then Linus did some work on this as well. > > > > How does this play with what Linus proposed? I think only portions of > > his original changes are merged, and there are still outstanding parts, > > right? > > Linus committed his proposed pty changes which sits in -rc6 and not > in tty-next (which is based on -rc5): > > commit 8ead9dd54716d1e05e129959f702fcc1786f82b4 > Author: Linus Torvalds <torvalds@linux-foundation.org> > Date: Mon Apr 25 20:04:08 2016 -0700 > > devpts: more pty driver interface cleanups > > This is more prep-work for the upcoming pty changes. Still just code > cleanup with no actual semantic changes. > > This removes a bunch pointless complexity by just having the slave pty > side remember the dentry associated with the devpts slave rather than > the inode. That allows us to remove all the "look up the dentry" code > for when we want to remove it again. > > .... > > > Linus's changes look good to me and I've been running them cherry-picked on > my private tty-next testing tree since. > > When Greg picks up -rc6 (not sure he was going to do that pre-merge window?), > I'd also like to push the devpts_mutex locking down into fs/devpts/inode.c, > but I'd be willing to do that later, if it's going to get in the way.
Ah, that's why I missed it, thanks.
It's late in the review cycle here Eric, how about I consider this after 4.7-rc1 is out to make it get more testing and so that others can build on it (as Peter describes)?
thanks,
greg k-h
| |