Messages in this thread | | | Date | Fri, 6 May 2016 09:17:01 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/6] perf tools: fix incorrect ordering of callchain entries |
| |
Em Thu, Apr 28, 2016 at 10:49:03AM +0200, Jiri Olsa escreveu: > On Thu, Apr 28, 2016 at 01:19:06AM -0700, Chris Phlipot wrote: > > The existing implementation of thread__resolve_callchain, under certain > > circumstances, can assemble callchain entries in the incorrect order. > > SNIP > > > 0x558f2a04c774 > > 0x558f2a04dded > > rand > > __random > > ret_from_intr > > do_IRQ > > handle_irq > > handle_edge_irq > > handle_irq_event > > handle_irq_event_percpu > > gen8_irq_handler > > > > Signed-off-by: Chris Phlipot <cphlipot0@gmail.com> > > for this patch > > Acked-by: Jiri Olsa <jolsa@kernel.org>
Tested, nice catch and fix, applied.
A good thing would be to be able to reverse the callchain order dynamicly, in the TUI, shouldn't be hard, right?
- Arnaldo
> can't really ack the rest of the patchset, but it looks good to me > > thanks, > jirka
| |