lkml.org 
[lkml]   [2016]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface
From
On Fri, May 6, 2016 at 2:20 PM, Maarten Brock <m.brock@vanmierlo.com> wrote:
>> > >
>> > > + bool polarity;
>> > So this variable is not very intuitively named.
>>
>> There is a help above. This is a property of the Synopsys DesignWare DMA
>> engine. Anyone familiar with datasheet easily understands this.
>>
>> >
>> > You end up setting somepointer->polarity = true; in a later patch.
>> >
>> > Since you're respining a V4 I'd suggest a name that describes a little
>> > bit better than polarity. Setting polarity = true is a little bit
>> > liked being asked "you you like ice-cream or apple pie" and then
>> > saying "yes please".
>>
>> It's about handshake interface polarity, so, what about hs_polarity?
>
> So it means: handshake has polarity (true) or handshake has no polarity
> (omnidirectional?) (false), right?

It means that handshake polarity _signal_ is inverted (true) or
default (false) in terms of hardware gates.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2016-05-06 14:01    [W:0.270 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site