lkml.org 
[lkml]   [2016]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rtc: add support for maxim rtc max6916
Hi,

On 05/05/2016 at 03:09:49 -0700, venkat.prashanth2498@gmail.com wrote :
> From: venkat-prashanth <venkat.prashanth2498@gmail.com>
>
> This a patch to add support for
> maxim rtc max6916
>
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
> ---
> ---
> drivers/rtc/rtc-max6916.c | 165 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 165 insertions(+)
>

This is the second version you send since my comments. Please include
the patch version in the subject line.
Also, you need to include a changelog.
Finally, you didn't address many of my comments please do so before
submitting again.


--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2016-05-05 13:21    [W:0.028 / U:1.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site