Messages in this thread | | | Subject | Re: [PATCH] ie31200_edac: add skylake support | From | Jason Baron <> | Date | Wed, 4 May 2016 15:03:44 -0400 |
| |
On 05/04/2016 01:44 PM, Luck, Tony wrote: >> I've verified that the 'ce_count' is correctly incrementing with bad dimms. > Did you re-test on at least one of the previous 3 generations of CPUs supported > by this driver? All would be nice, but the bulk of the opportunities for cut&paste > errors seem to be in code that looks like: > > if (Skylake) > do new thing > else > do old thing > > so if one of them still works, it's likely they all do. > > -Tony
Hi Tony,
I verified that at least the memory sizes, ie the 'size_mb' files are correct on the old h/w. I don't have bad dimms atm to test the old h/w error paths though. That said this driver does get a lot indirect testing here (just from being loaded), - so I would likely find out if there were regressions.
Thanks,
-Jason
| |