Messages in this thread | | | Date | Wed, 4 May 2016 09:28:34 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH v4 2/3] USB: serial: cp210x: Got rid of magic numbers in CRTSCTS flag code. |
| |
On Tue, May 03, 2016 at 07:52:23PM -0500, Konstantin Shkolnyy wrote: > Replaced magic numbers used in the CRTSCTS flag code with symbolic names > from the chip specification. > > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
This patch does not even compile. Please be more careful when resubmitting. There are at least two compilation errors below.
> --- > v4: > Same series of patches, fixed names and defines by feedback. > v3: > Regenerated the patches correctly against the latest usb-next branch. > v2 > Improved CRTSCTS fix by feedback. Dropped get_termios error handling fix.
In the future, if you have an aggregate changelog for a series, put it in a cover letter. A cover letter is good to have anyway and should provide a high-level summary of what the series does.
Thanks, Johan
| |