lkml.org 
[lkml]   [2016]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] qed: fix qed_fill_link() error handling
From
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Mon, 30 May 2016 16:24:07 +0000

>> + if (IS_ENABLED(CONFIG_QED_SRIOV) && !IS_PF(hwfn->cdev)) {
>> + qed_vf_get_link_params(hwfn, params);
>> + qed_vf_get_link_state(hwfn, link);
>> + qed_vf_get_link_caps(hwfn, link_caps);
>> +
>> + return 0;
>> + }
>
> The IS_ENABLED here seems a bit wasteful to me - we have empty implementation
> under qed_vf.h just for this case [I.e., that SRIOV isn't enabled for qed].
> If all we're trying achieve is removing these gcc warnings, I think we can simply
> memset the structs in the currently-empty qed_vf_get_link_* functions.

I think both solutions are equally valid/elegant.

Arnd?

\
 
 \ /
  Last update: 2016-05-31 23:41    [W:0.215 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site