lkml.org 
[lkml]   [2016]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH perf/core v9 01/16] perf-symbol: Introduce filename__readable to check readability
On Mon, 30 May 2016 13:04:47 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Mon, May 30, 2016 at 01:03:17PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Sun, May 29, 2016 at 12:15:13AM +0900, Masami Hiramatsu escreveu:
> > > Introduce filename__readable to check readability by opening
> > > the file directly. Since the access(R_OK) just checks the
> > > readability based on real UID/GID, it is ignored that the
> > > effective UID/GID and capabilities for some special file (e.g.
> > > /proc/kcore).
> > > filename__readable() directly opens given file with O_RDONLY
> > > so that the kernel checks it by effective UID/GID and capabilities.
> >
> >
> > You missed the Signed-off-by line.
>
> This this for you this time, no need to resend.

Oops, and thanks!!

>
> - Arnaldo


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2016-05-31 08:21    [W:0.060 / U:1.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site