lkml.org 
[lkml]   [2016]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/17] x86: get rid of superfluous __GFP_REPEAT
    Date
    From: Michal Hocko <mhocko@suse.com>

    __GFP_REPEAT has a rather weak semantic but since it has been introduced
    around 2.6.12 it has been ignored for low order allocations.

    PGALLOC_GFP uses __GFP_REPEAT but none of the allocation which uses this
    flag is for more than order-0. This means that this flag has never
    been actually useful here because it has always been used only for
    PAGE_ALLOC_COSTLY requests.

    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: linux-arch@vger.kernel.org
    Signed-off-by: Michal Hocko <mhocko@suse.com>
    ---
    arch/x86/kernel/espfix_64.c | 2 +-
    arch/x86/mm/pgtable.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kernel/espfix_64.c b/arch/x86/kernel/espfix_64.c
    index 4d38416e2a7f..04f89caef9c4 100644
    --- a/arch/x86/kernel/espfix_64.c
    +++ b/arch/x86/kernel/espfix_64.c
    @@ -57,7 +57,7 @@
    # error "Need more than one PGD for the ESPFIX hack"
    #endif

    -#define PGALLOC_GFP (GFP_KERNEL | __GFP_NOTRACK | __GFP_REPEAT | __GFP_ZERO)
    +#define PGALLOC_GFP (GFP_KERNEL | __GFP_NOTRACK | __GFP_ZERO)

    /* This contains the *bottom* address of the espfix stack */
    DEFINE_PER_CPU_READ_MOSTLY(unsigned long, espfix_stack);
    diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
    index 4eb287e25043..aa0ff4b02a96 100644
    --- a/arch/x86/mm/pgtable.c
    +++ b/arch/x86/mm/pgtable.c
    @@ -6,7 +6,7 @@
    #include <asm/fixmap.h>
    #include <asm/mtrr.h>

    -#define PGALLOC_GFP GFP_KERNEL | __GFP_NOTRACK | __GFP_REPEAT | __GFP_ZERO
    +#define PGALLOC_GFP GFP_KERNEL | __GFP_NOTRACK | __GFP_ZERO

    #ifdef CONFIG_HIGHPTE
    #define PGALLOC_USER_GFP __GFP_HIGHMEM
    --
    2.8.1
    \
     
     \ /
      Last update: 2016-05-30 11:41    [W:5.530 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site