Messages in this thread | | | Date | Tue, 31 May 2016 12:52:13 +1000 | From | Stephen Rothwell <> | Subject | linux-next: build warnings after merge of the rtc tree |
| |
Hi Alexandre,
After merging the rtc tree, today's linux-next build (x86_64 allmodconfig) produced these warnings:
In file included from drivers/char/mwave/smapi.c:51:0: drivers/char/mwave/smapi.h:52:0: warning: "TRUE" redefined #define TRUE 1 ^ In file included from include/acpi/acpi.h:58:0, from include/linux/acpi.h:33, from include/linux/mc146818rtc.h:21, from drivers/char/mwave/smapi.c:50: include/acpi/actypes.h:438:0: note: this is the location of the previous definition #define TRUE (1 == 1) ^ In file included from drivers/char/mwave/smapi.c:51:0: drivers/char/mwave/smapi.h:53:0: warning: "FALSE" redefined #define FALSE 0 ^ In file included from include/acpi/acpi.h:58:0, from include/linux/acpi.h:33, from include/linux/mc146818rtc.h:21, from drivers/char/mwave/smapi.c:50: include/acpi/actypes.h:433:0: note: this is the location of the previous definition #define FALSE (1 == 0) ^
Introduced by commit
fd09cc80165c ("rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h")
Why the hell do we have any definitions of TRUE and FALSE, anyway? There are a few more (I counted 4 in header files before stopping).
Hmmm, those 2 static inline functions in include/linux/mc146818rtc.h that reference ACPI stuff are probably to big to be inline and in a header file anyway, right?
-- Cheers, Stephen Rothwell
| |