lkml.org 
[lkml]   [2016]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop
From
Date
On Tue, 2016-05-03 at 15:40 +0200, Oleg Nesterov wrote:
> On 05/02, Andrew Morton wrote:
> >
> >
> > On Mon, 02 May 2016 23:17:41 +0300 Oleksandr Natalenko wrote:
> >
> > >
> > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in
> > > uninterruptible sleep still contribute to the load average (for
> > > bug-compatibility with Unix).
> We have TASK_NOLOAD/TASK_IDLE, you can just use schedule_timeout_idle(HZ).
[...]

I wasn't aware of that function... ah, that would be because it's new
in 4.6.  It seems much clearer to use that than to use
msleep_interruptible() and ignore the result.

Ben.

--
Ben Hutchings
In a hierarchy, every employee tends to rise to his level of incompetence.[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-05-03 18:01    [W:0.062 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site