Messages in this thread | | | Subject | Re: [PATCH v2 2/4] x86, boot: PUD VA support for physical mapping (x86_64) | From | Dave Hansen <> | Date | Tue, 3 May 2016 08:08:51 -0700 |
| |
On 05/03/2016 03:05 AM, Baoquan He wrote: > I have a tiny concern about phys_pmd_init(), both phys_pud_init and > phys_pte_init name 2nd parameter as 'addr', phys_pmd_init use 'address'. > If this can be changed to make them look consistent completist would > have a good sleep from now on.
Yes, consistency would be nice. Even better would be to call them all 'phys_addr'.
| |