Messages in this thread | | | Subject | Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get variable flags | From | Paolo Bonzini <> | Date | Fri, 27 May 2016 18:06:04 +0200 |
| |
On 27/05/2016 17:40, Andy Lutomirski wrote: > On Thu, May 26, 2016 at 11:17 PM, Minfei Huang <mnghuan@gmail.com> wrote: >> There is a generic function __pvclock_read_cycles to be used to get both >> flags and cycles. For function pvclock_read_flags, it's useless to get >> cycles value. To make this function be more effective, add a new wrapper >> function to only get variable flags. > > Why not just get rid of this function entirely?
I agree. If you want to abstract the retry logic, perhaps you can add pvclock_read_{begin,retry} functions like seqlock_read_{begin,retry}?
Thanks,
Paolo
| |