lkml.org 
[lkml]   [2016]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.
    On 26/05/16 09:01, Shubham Bansal wrote:
    > Fixed a coding style issue. Issue reported by checkpatch.pl.
    >
    > Signed-off-by: Shubham Bansal <illusionist.neo@gmail.com>
    > ---
    > drivers/staging/android/ion/ion.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
    > index 8536567..2217ccb 100644
    > --- a/drivers/staging/android/ion/ion.c
    > +++ b/drivers/staging/android/ion/ion.c
    > @@ -184,7 +184,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
    > struct scatterlist *sg;
    > int i, ret;
    >
    > - buffer = kzalloc(sizeof(struct ion_buffer), GFP_KERNEL);
    > + buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
    > if (!buffer)
    > return ERR_PTR(-ENOMEM);
    >
    >


    This patch looks good.

    It is not a big issue, but have it in mind for the future. When fixing issues
    reported by checkpatch, it is nice to paste the output warning of checkpatch
    in the commit message.

    Look at this example:
    https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=e7a142aaa09fa5db015fd176d6943f888665829f

    Thanks,
    Luis

    \
     
     \ /
      Last update: 2016-05-26 15:01    [W:3.108 / U:1.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site