Messages in this thread Patch in this message | | | From | Baoquan He <> | Subject | [Patch v4 1/9] iommu/amd: clean up the cmpxchg64 invocation | Date | Wed, 25 May 2016 14:28:47 +0800 |
| |
Change it as it's designed for and keep it consistent with other places.
Signed-off-by: Baoquan He <bhe@redhat.com> --- drivers/iommu/amd_iommu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index 5efadad..9ec7cad 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers/iommu/amd_iommu.c @@ -1287,7 +1287,8 @@ static u64 *alloc_pte(struct protection_domain *domain, __npte = PM_LEVEL_PDE(level, virt_to_phys(page)); - if (cmpxchg64(pte, __pte, __npte)) { + /* pte could have been changed somewhere. */ + if (cmpxchg64(pte, __pte, __npte) != __pte) { free_page((unsigned long)page); continue; } -- 2.5.5
| |