lkml.org 
[lkml]   [2016]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/1] sysctl: introduce uuid_le and uuid_be
From
Date
On Tue, 2016-05-24 at 13:15 -0700, Andrew Morton wrote:
> On Tue, 24 May 2016 20:27:27 +0300 Andy Shevchenko <andriy.shevchenko@
> linux.intel.com> wrote:
>
> > By default the sysctl interface returns random UUID in big endian
> > format.
> > Sometimes it's not suitable, e.g. using generated UUID for EFI
> > variable name.
> > Provide uuid_le and uuid_be to comprehence that interface.
> >
> > ...
> >
> >  drivers/char/random.c       | 44
> > +++++++++++++++++++++++++++++++++++++++++
> >  include/uapi/linux/sysctl.h |  4 +++-
> >  kernel/sysctl_binary.c      | 48
> > ++++++++++++++++++++++++++++++++++++++++++++
>
> Why does the kernel need to do this?  If userspace wants a random uuid
> then it can grab a random number and cook up the UUID itself.

Good question. I dunno why we have uuid in the first place there. At
some point I noticed people who recommend to use that file to get a
random UUID(s), but apparently they don't aware that endianess matters. 

P.S. I thought to send this as RFC, but decided to drop the notation in
last minute. So, it's okay to drop it.

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

\
 
 \ /
  Last update: 2016-05-24 22:41    [W:0.070 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site