lkml.org 
[lkml]   [2016]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition
On Thursday 19 May 2016 11:13:04 Pali Rohár wrote:
> On Saturday 09 January 2016 23:42:30 Pali Rohár wrote:
> > On Friday 01 January 2016 12:26:21 Pali Rohár wrote:
> > > On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote:
> > > > All calls to isp1704_write() are using parameter sequence of
> > > > isp1704_write(isp, reg, val) but the function is defined as
> > > > isp1704_write(isp, val, reg). Fix isp1704_write function definition
> > > > so that the driver to be functional.
> > > >
> > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > >
> > > Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> > >
> > > This problem is there since inclusion of driver itself. No idea why
> > > that driver could work... I remember that it detected correctly type
> > > of charger.
> > >
> > > I will test this patch on real N900 HW in one or two weeks to check
> > > how it behave after patching...
> >
> > Tested-by: Pali Rohár <pali.rohar@gmail.com>
> >
> > Please send this patch to all stable kernels.
>
> Hi! I still think that this patch should go to stable kernels. Because
> without it driver does not work... Will somebody send it to stable?

So no objections, I sent it to stable@vger.kernel.org.

--
Pali Rohár
pali.rohar@gmail.com

\
 
 \ /
  Last update: 2016-05-24 18:01    [W:0.401 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site