lkml.org 
[lkml]   [2016]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/6] Input: soc_button_array fixes and support of the Surface 3
On May 17 2016 or thereabouts, Bastien Nocera wrote:
> On Fri, 2016-05-13 at 18:05 +0200, Benjamin Tissoires wrote:
> > Hi,
> >
> > This is the v2 of the series with 3 extra patches to add support of
> > the buttons
> > found on the Surface 3.
> >
> > Cheers,
> > Benjamin
> >
> >
> > Benjamin Tissoires (6):
> >   Input - soc_button_array: use gpio_is_valid()
> >   Input - soc_button_array: bail out earlier if gpiod_count is null
> >   Input - soc_button_array: make sure one GPIO is not assigned twice
> >   Input - soc_button_array: allow to specify active_low
> >   Input - soc_button_array: export part of the internals
> >   Input - surface3_button_array: Introduce button support for the
> >     Surface 3
>
> Works on my Surface 3, the volume buttons, and the Windows button work
> as expected. Note that the power button does not send out any events on
> my machine, but that might be due to firmware differences.
>
> My BIOS is listed as version 1.51116.78 released 03/09/2015.
>
> As there's no errors generated, it would be fine to look at it as a bug
> fix later on (or for me to updated my system).
>
> Tested-by: Bastien Nocera <hadess@hadess.net>

Bastien told me in a different thread that the power button is not
working only after a reboot from Windows. After a cold start, it works
fine. There might be something that needs to be set at the I2C level,
but I think while we don't know much about the I2C protocol there, it
should be safe to still get this upstream.

Cheers,
Benjamin

\
 
 \ /
  Last update: 2016-05-20 10:21    [W:0.808 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site