lkml.org 
[lkml]   [2016]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] NVMe: fix deadlock on failure branch in nvme_get_ns_from_disk()
On Sat, May 21, 2016 at 01:36:00AM +0300, Alexey Khoroshilov wrote:
> kref_put(&ns->kref, nvme_free_ns) is called in nvme_get_ns_from_disk()
> under dev_list_lock spinlock, while nvme_free_ns() locks the spinlock
> by itself. This can lead to a deadlock.
>
> The patch moves try_module_get() and its error handling
> out of spinlock section.

This is also fixed with this earlier posted patch:

http://lists.infradead.org/pipermail/linux-nvme/2016-May/004530.html

\
 
 \ /
  Last update: 2016-05-21 01:21    [W:0.473 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site