lkml.org 
[lkml]   [2016]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] iio: humidity: hdc100x: correct humidity integration time mask
Reviewed-by: Matt Ranostay <mranostay@gmail.com>

On Fri, May 20, 2016 at 10:06 AM, Alison Schofield <amsfield22@gmail.com> wrote:
> Apply the correct mask to enable all available humidity integration
> times. Currently, the driver defaults to 6500 and all is okay with that.
> However, if 3850 is selected we get a stuck bit and can't change back
> to 6500 or select 2500. (Verified with HDC1008)
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> ---
> drivers/iio/humidity/hdc100x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index fa47676..59aa1cb 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -55,7 +55,7 @@ static const struct {
> },
> { /* IIO_HUMIDITYRELATIVE channel */
> .shift = 8,
> - .mask = 2,
> + .mask = 3,

Yikes that is embarrassing on my part! I guess our validation was only
in the high resolution mode... good catch!

> },
> };
>
> --
> 2.1.4
>

\
 
 \ /
  Last update: 2016-05-20 20:01    [W:0.076 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site