Messages in this thread | | | Date | Fri, 20 May 2016 12:24:56 +0200 | From | Jiri Olsa <> | Subject | Re: Add top down metrics to perf stat |
| |
On Fri, May 13, 2016 at 06:44:49PM -0700, Andi Kleen wrote: > Note to reviewers: includes both tools and kernel patches. > The kernel patches are at the beginning. > > [v2: Address review feedback. > Metrics are now always printed, but colored when crossing threshold. > --topdown implies --metric-only. > Various smaller fixes, see individual patches] > [v3: Add --single-thread option and support it with HT off. > Clean up old HT workaround. > Improve documentation. > Various smaller fixes, see individual patches.] > [v4: Rebased on latest tree] > [v5: Rebased on latest tree. Move debug messages to -vv] > [v6: Rebased. Remove .aggr-per-core and --single-thread to not > break old perf binaries. Put SMT enumeration into > generic topology API.] > [v7: Address review comments. Change patch title headers.]
other than the missing headers and unnneeded initialization of have_frontend_stalled I'm ok with the perf tools part
thanks, jirka
| |