lkml.org 
[lkml]   [2016]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.5 109/200] toshiba_acpi: Fix regression caused by hotkey enabling value
    Date
    4.5-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Azael Avalos <coproscefalo@gmail.com>

    commit a30b8f81d9d6fe24eab8a023794548b048f08e3c upstream.

    Commit 52cbae0127ad ("toshiba_acpi: Change default Hotkey enabling value")
    changed the hotkeys enabling value, as it was the same value Windows uses,
    however, it turns out that the value tells the EC that the driver will now
    take care of the hardware events like the physical RFKill switch or the
    pointing device toggle button.

    This patch reverts such commit by changing the default hotkey enabling
    value to 0x09, which enables hotkey events only, making the hardware
    buttons working again.

    Fixes bugs 113331 and 114941.

    Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
    Signed-off-by: Darren Hart <dvhart@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/platform/x86/toshiba_acpi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/platform/x86/toshiba_acpi.c
    +++ b/drivers/platform/x86/toshiba_acpi.c
    @@ -133,7 +133,7 @@ MODULE_LICENSE("GPL");
    /* Field definitions */
    #define HCI_ACCEL_MASK 0x7fff
    #define HCI_HOTKEY_DISABLE 0x0b
    -#define HCI_HOTKEY_ENABLE 0x01
    +#define HCI_HOTKEY_ENABLE 0x09
    #define HCI_HOTKEY_SPECIAL_FUNCTIONS 0x10
    #define HCI_LCD_BRIGHTNESS_BITS 3
    #define HCI_LCD_BRIGHTNESS_SHIFT (16-HCI_LCD_BRIGHTNESS_BITS)

    \
     
     \ /
      Last update: 2016-05-03 03:21    [W:4.376 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site