lkml.org 
[lkml]   [2016]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 048/163] crypto: sha1-mb - use corrcet pointer while completing jobs
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Xiaodong Liu <xiaodong.liu@intel.com>

    commit 0851561d9c965df086ef8a53f981f5f95a57c2c8 upstream.

    In sha_complete_job, incorrect mcryptd_hash_request_ctx pointer is used
    when check and complete other jobs. If the memory of first completed req
    is freed, while still completing other jobs in the func, kernel will
    crash since NULL pointer is assigned to RIP.

    Signed-off-by: Xiaodong Liu <xiaodong.liu@intel.com>
    Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/crypto/sha-mb/sha1_mb.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/arch/x86/crypto/sha-mb/sha1_mb.c
    +++ b/arch/x86/crypto/sha-mb/sha1_mb.c
    @@ -453,10 +453,10 @@ static int sha_complete_job(struct mcryp

    req = cast_mcryptd_ctx_to_req(req_ctx);
    if (irqs_disabled())
    - rctx->complete(&req->base, ret);
    + req_ctx->complete(&req->base, ret);
    else {
    local_bh_disable();
    - rctx->complete(&req->base, ret);
    + req_ctx->complete(&req->base, ret);
    local_bh_enable();
    }
    }

    \
     
     \ /
      Last update: 2016-05-03 02:41    [W:4.148 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site