Messages in this thread | | | Date | Mon, 2 May 2016 16:42:03 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines |
| |
On Mon, May 02, 2016 at 08:11:24AM -0500, Bjorn Helgaas wrote: > On Sun, May 01, 2016 at 08:01:49PM +0200, Christoph Hellwig wrote: > > FYI, I spent some time trying to convert more drivers to this, and > > I think we'll need an additional flag to skip MSI or MSI-X as there > > is plenty of hardware claiming support in the capabilities flag, > > but not actually supporting one of them. > > Or maybe add a "pdev->msix_broken" bit and quirks to set it? Or if > pci_fixup_final quirks merely cleared pdev->msix_cap, I think the PCI > core would never try to enable MSI-X.
Can't say I'm excited about quirks - now we'd have to patch core code for something that previously was entirely in the driver.
| |