Messages in this thread | | | Subject | Re: [PATCH v3 5/5] mmc: sdhci-of-arasan: implement enhanced strobe callback | From | Shawn Lin <> | Date | Fri, 20 May 2016 09:49:11 +0800 |
| |
Hi
在 2016-5-20 8:11, Doug Anderson 写道: > Hi, > > On Tue, May 10, 2016 at 2:10 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote: >> Currently sdhci-arasan 5.1 can support enhanced strobe function, >> and we now limit it just for "arasan,sdhci-5.1". Add >> mmc-hs400-enhanced-strobe in DT to enable the function if we'r sure > > nit:s/we'r/we're/ > > [ ... ] >> @@ -79,6 +81,21 @@ static void sdhci_arasan_set_clock(struct sdhci_host *host, unsigned int clock) >> } >> } >> >> +static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc, >> + struct mmc_ios *ios) >> +{ >> + u32 vendor; >> + struct sdhci_host *host = mmc_priv(mmc); >> + >> + vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER); >> + if (ios->enhanced_strobe) >> + vendor |= VENDOR_ENHANCED_STROBE; >> + else >> + vendor &= (~VENDOR_ENHANCED_STROBE); > > nit: no extra parentheses: > > vendor &= ~VENDOR_ENHANCED_STROBE; > > > Other than the nits this patch looks good to me. Feel free to add my > Reviewed-by when nits fixed.
okay, will fix them.
Thanks for your review!
> > -Doug > > >
| |