lkml.org 
[lkml]   [2016]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCHv2] usb: USB Type-C Connector Class
On Thu, May 19, 2016 at 04:48:46PM +0200, Oliver Neukum wrote:
> On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote:
>
> > + dev->class = &typec_class;
> > + dev->parent = parent;
> > + dev->type = &typec_partner_dev_type;
> > + dev_set_name(dev, "%s-partner", dev_name(&port->dev));
> > +
> > + ret = device_register(dev);
> > + if (ret) {
> > + put_device(dev);
> > + return ret;
> > + }
>
> This looks like a race condition.

Really? How?

> > + ret = typec_register_altmodes(dev, partner->alt_modes);
> > + if (ret) {
> > + device_unregister(dev);
> > + return ret;
> > + }
> > +
> > + /* REVISIT: Creating symlink for the port device for now. */
> > + ret = sysfs_create_link(&port->dev.kobj, &dev->kobj, "partner");
> > + if (ret)
> > + dev_WARN(&port->dev, "failed to create link to %s (%d)\n",
> > + dev_name(dev), ret);
>
> The attributes should be present as soon as the device is announced.

Yes, this is wrong and racy (hint, if you have to drop down to a sysfs
call within a driver, almost always something is wrong...)

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-05-19 18:01    [W:0.632 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site