Messages in this thread | | | Subject | Re: [PATCH 0/6] ARM: dts: sun5i: q8-common: Enable various peripherals | From | Hans de Goede <> | Date | Wed, 18 May 2016 10:13:52 +0200 |
| |
Hi Chen-Yu,
On 17-05-16 17:56, Chen-Yu Tsai wrote: > Hi everyone, > > This series enables more peripherals for Allwinner A13-based Q8 devices. > The peripherals include the WiFi, the PMIC's micro-usb power supply > (driver), audio codec (headphone and speaker), and full display support > with the new DRM KMS driver. The series is based on parts of Maxime's > "drm: Add Support for Passive RGB to VGA bridges" series, specifically > the clk and drm fixes, and common DTS bits. > > Hans, since you have a collection of q8 tablets, I'm hoping you could > test these bits and provide some feedback.
I've not run any tests, just looked at the patches, the stuff in patch 3 is already present in arch/arm/boot/dts/sun5i-a13-q8-tablet.dts I put it there because I saw some .fex files which don't use ldo3 for wifi I'm fine with moving it to -common though, I believe that you're right that it makes more sense there, having it in 2 places is not really useful though.
The other patches look good.
Thanks & Regards,
Hans
> > > Patch 1 is a small fix for part of the init failure path. > > Patch 2 disables ldo5 on the axp209 by default. This regulator output is > muxed with a gpio, and the regulator on/off settings override the gpio. > > Patch 3 enables the USB WiFi module found. > > Patch 4 enables the USB/VBUS power supply of the PMIC. > > Patch 5 enables the audio codec, with support for the speaker amp. > > Patch 6 enables the LCD panel with the display pipeline. > > > Regards > ChenYu > > > Chen-Yu Tsai (6): > drm: sun4i: do cleanup if RGB output init fails > ARM: dts: axp209: Disable ldo5 by default > ARM: dts: sun5i: q8-common: Enable USB-based WiFi > ARM: dts: sun5i: q8-common: Enable USB power supply > ARM: dts: sun5i: q8-common: Enable audio codec > ARM: dts: sun5i: q8-common: Enable display pipeline and LCD display > > arch/arm/boot/dts/axp209.dtsi | 1 + > arch/arm/boot/dts/sun5i-q8-common.dtsi | 62 ++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/sun4i/sun4i_tcon.c | 6 +++- > 3 files changed, 68 insertions(+), 1 deletion(-) >
| |