| Date | Wed, 18 May 2016 15:56:45 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v12 07/13] task_isolation: add debug boot flag |
| |
On Tue, Apr 05, 2016 at 01:38:36PM -0400, Chris Metcalf wrote: > +#ifdef CONFIG_TASK_ISOLATION > +void task_isolation_debug(int cpu) > +{ > + struct task_struct *p; > + > + if (!task_isolation_possible(cpu)) > + return; > + > + rcu_read_lock(); > + p = cpu_curr(cpu); > + get_task_struct(p); > + rcu_read_unlock(); > + task_isolation_debug_task(cpu, p); > + put_task_struct(p);
This is still broken...
Also, I really don't like how you sprinkle a call all over the core kernel. At the very least make an inline fast path for this function to avoid the call whenever possible.
> +} > +#endif
|