Messages in this thread | | | Subject | Re: [PATCH 01/14] staging: comedi: daqboard2000: remove commented out code | From | Ian Abbott <> | Date | Wed, 18 May 2016 11:21:54 +0100 |
| |
On 17/05/16 18:14, Hartley Sweeten wrote: > On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: >> Remove some commented out code. Some of it uses constructs that don't >> exist in the driver, and probably come from the source code for the MS >> Windows driver. >> >> Signed-off-by: Ian Abbott <abbotti@mev.co.uk> >> --- >> drivers/staging/comedi/drivers/daqboard2000.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c >> index 57ab668..8c9a024 100644 >> --- a/drivers/staging/comedi/drivers/daqboard2000.c >> +++ b/drivers/staging/comedi/drivers/daqboard2000.c [snip] >> @@ -315,10 +313,6 @@ static void setup_sampling(struct comedi_device *dev, int chan, int gain) >> word3 = 0; >> break; >> } >> -/* >> - dev->eeprom.correctionDACSE[i][j][k].offset = 0x800; >> - dev->eeprom.correctionDACSE[i][j][k].gain = 0xc00; >> -*/ >> /* These should be read from EEPROM */ >> word2 |= 0x0800; >> word3 |= 0xc000; > > It might be a good idea to add a comment about the magic 0x0800 and 0xc000 values: > >> word2 |= 0x0800; /* offset */ >> word3 |= 0xc000; /* gain */
Fair enough.
> Wish I could find a register map for this board. I sent an email to Measurement Computing > to see if one is available.
I think the board was made by IOTech and added to Measurement Computing's catalog, and the Windows driver appears to have been done by IOTech too.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |