Messages in this thread | | | Subject | Re: [lkp] [xfs] a08ee40a79: kmsg.XFS(vdd):unknown_mount_option[nosuchopt] | From | Eric Sandeen <> | Date | Mon, 16 May 2016 10:46:04 -0500 |
| |
On 5/15/16 8:42 PM, kernel test robot wrote: > FYI, we noticed the following commit: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > commit a08ee40a79653d082911cab9fbeff94baa7714cb ("xfs: sanitize remount options") > > on test machine: vm-kbuild-4G: 4 threads qemu-system-x86_64 -enable-kvm -cpu qemu64,+ssse3 with 4G memory > > caused below changes: > > > [ 666.729855] XFS (vdd): unknown mount option [nosuchopt].
This is expected, it's just that we're catching invalid remount options, now, and being a bit noiser about it.
default: xfs_warn(mp, "unknown mount option [%s].", p); return -EINVAL;
From tests/generic/082 :
# first remount ro with a bad option, a failed remount ro should not disable # quota, but currently xfs doesn't fail in this case, the unknown option is # just ignored, but quota is still on. This may change in future, let's # re-consider the case then. _scratch_mount "-o remount,ro,nosuchopt" >>$seqres.full 2>&1
so the test is intentionally passing in a bad mount option, and the kernel is just letting us know.
Thanks, -Eric
| |