lkml.org 
[lkml]   [2016]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/2] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 15 May 2016 19:20:28 +0200

    The platform_device_put() function was called in one case by the
    add_numbered_child() function during error handling even if the passed
    variable "pdev" contained a null pointer.

    * Change an error message.

    * Return directly in this case.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/mfd/twl-core.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
    index 831696e..dc34e69 100644
    --- a/drivers/mfd/twl-core.c
    +++ b/drivers/mfd/twl-core.c
    @@ -623,9 +623,10 @@ add_numbered_child(unsigned mod_no, const char *name, int num,

    pdev = platform_device_alloc(name, num);
    if (!pdev) {
    - dev_dbg(&twl->client->dev, "can't alloc dev\n");
    - status = -ENOMEM;
    - goto err;
    + dev_err(&twl->client->dev,
    + "Allocation failed for device: %s\n",
    + name);
    + return ERR_PTR(-ENOMEM);
    }

    pdev->dev.parent = &twl->client->dev;
    --
    2.8.2
    \
     
     \ /
      Last update: 2016-05-16 08:41    [W:4.554 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site