lkml.org 
[lkml]   [2016]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH net-next] tuntap: introduce tx skb ring
    From
    Date
    On Mon, 2016-05-16 at 09:17 +0800, Jason Wang wrote:
    > We used to queue tx packets in sk_receive_queue, this is less
    > efficient since it requires spinlocks to synchronize between producer
    > and consumer.

    ...

    > struct tun_struct *detached;
    > + /* reader lock */
    > + spinlock_t rlock;
    > + unsigned long tail;
    > + struct tun_desc tx_descs[TUN_RING_SIZE];
    > + /* writer lock */
    > + spinlock_t wlock;
    > + unsigned long head;
    > };
    >

    Ok, we had these kind of ideas floating around for many other cases,
    like qdisc, UDP or af_packet sockets...

    I believe we should have a common set of helpers, not hidden in
    drivers/net/tun.c but in net/core/skb_ring.c or something, with more
    flexibility (like the number of slots)


    BTW, why are you using spin_lock_irqsave() in tun_net_xmit() and
    tun_peek() ?

    BH should be disabled already (in tun_next_xmit()), and we can not
    transmit from hard irq.

    Thanks.



    \
     
     \ /
      Last update: 2016-05-16 06:41    [W:7.235 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site