Messages in this thread | | | Subject | Re: [PATCH v2 1/2] vb2: core: Skip planes array verification if pb is NULL | From | Sakari Ailus <> | Date | Fri, 13 May 2016 12:38:26 +0300 |
| |
Hi Hans,
Hans Verkuil wrote: > On 05/12/2016 02:14 PM, Sakari Ailus wrote: >> An earlier patch fixing an input validation issue introduced another >> issue: vb2_core_dqbuf() is called with pb argument value NULL in some >> cases, causing a NULL pointer dereference. Fix this by skipping the >> verification as there's nothing to verify. >> >> Signed-off-by: David R <david@unsolicited.net> >> >> Use if () instead of ? :; it's nicer that way. Improve the comment in the >> code as well. > > This comment doesn't seem applicable to this patch.
Compared to the original patch. I can sure drop the comment as well, it's not that important.
> > Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
Thanks!
-- Sakari Ailus sakari.ailus@linux.intel.com
| |