Messages in this thread | | | Date | Fri, 13 May 2016 06:06:53 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH RFT 1/2] phylib: add device reset GPIO support |
| |
> >>+ gpiod = fwnode_get_named_gpiod(&child->fwnode, "reset-gpios"); > >>+ /* Deassert the reset signal */ > >>+ if (!IS_ERR(gpiod)) > >>+ gpiod_direction_output(gpiod, 0); > > > >This is wrong I think. You must only ignore -ENODEV, all other error > > At least -ENOSYS should also be ignored (it's returned when > gpiolib is not configured), right? When does -ENODEV gets returned > (it's not easy to follow)? > > >codes should be passed to the caller. > > The caller doesn't care anyway...
It should do. What if fwnode_get_named_gpiod() returns -EPROBE_DEFER because the GPIO driver has not been loaded yet?
Andrew
| |