Messages in this thread | | | Date | Wed, 11 May 2016 11:04:38 +0300 | From | Yury Norov <> | Subject | Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it |
| |
On Wed, May 11, 2016 at 10:04:16AM +0800, Zhangjian (Bamvor) wrote: [...]
> >>Ok, I will test the ltp syscall test. > >>With this changes, the issue I mentioned should be fixed. But we still > >>use mmap2 syscall for ILP32 application when we pass the offset instead > >>of page offset. Is it correct? > > > >I don't remember. It's probably not important whether we have the shift > >in there, as long as it's independent of the actual kernel page size and > >user space and kernel agree on the calling conventions. > Well. I am ok with where to shift the pages size because we get the same > result. I was just thinking if we should get rid of the name of mmap2 in our > ILP32 porting. Actually, it is mmap but we name it as mmap2. User may confused > if they do not know the implementations. >
This is what generic unistd.h does. If you want to change it, you'd change each arch that uses generic unistd.h.
> Regards > > Bamvor > > > > > Arnd > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
| |