lkml.org 
[lkml]   [2016]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bcache: bch_writeback_thread() is not freezable
On Tue, 10 May 2016, Eric Wheeler wrote:

> > > bch_writeback_thread() is calling try_to_freeze(), but that's just an
> > > expensive no-op given the fact that the thread is not marked freezable.
> > >
> > > I/O helper kthreads, exactly such as the bcache writeback thread, actually
> > > shouldn't be freezable, because they are potentially necessary for
> > > finalizing the image write-out.
> > >
> > > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> >
> > Let's send a friendly ping on these three patches after two weeks...
>
> Maciej,
>
> Were you able to get a backtrace?

While I'd definitely like to understand the issues in interaction between
hibernation and bcache Maciej is supposedly seeing, this shouldn't hold
the application of the three patches in this series, as they are just a
cleanup that doesn't affect the behavior of the code in question.

Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2016-05-11 10:21    [W:0.141 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site