lkml.org 
[lkml]   [2016]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/13] perf script: Fix symbol insertion behavior in db-export
    Date
    From: Chris Phlipot <cphlipot0@gmail.com>

    Use the dso__insert_symbol function instead of symbols__insert() in
    order to properly update the dso symbol cache.

    If the cache is not updated, then duplicate symbols can be
    unintentionally created, inserted, and exported.

    This change prevents duplicate symbols from being exported due to
    dso__find_symbol() using a stale symbol cache.

    Signed-off-by: Chris Phlipot <cphlipot0@gmail.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/1462937209-6032-3-git-send-email-cphlipot0@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/db-export.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/tools/perf/util/db-export.c b/tools/perf/util/db-export.c
    index f8e3057ae3b1..2ef1f692c35b 100644
    --- a/tools/perf/util/db-export.c
    +++ b/tools/perf/util/db-export.c
    @@ -260,8 +260,7 @@ static int db_ids_from_al(struct db_export *dbe, struct addr_location *al,
    if (!al->sym) {
    al->sym = symbol__new(al->addr, 0, 0, "unknown");
    if (al->sym)
    - symbols__insert(&dso->symbols[al->map->type],
    - al->sym);
    + dso__insert_symbol(dso, al->map->type, al->sym);
    }

    if (al->sym) {
    --
    2.5.5
    \
     
     \ /
      Last update: 2016-05-11 19:01    [W:3.231 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site