lkml.org 
[lkml]   [2016]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES

* Dave Hansen <dave.hansen@linux.intel.com> wrote:

> On 05/10/2016 04:29 PM, Yu-cheng Yu wrote:
> > XSAVES uses compacted format and is a kernel instruction. The kernel
> > should use standard-format, non-supervisor state data for PTRACE.
> >
> > Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
>
> This looks fine. There are a few comments that could use some sprucing
> up, like:
>
> + /*
> + * Reject if the user sets any forbidden features.
> + */
>
> But it's minor stuff.
>
> Reviewed-by: Dave Hansen <dave.hansen@intel.com>

Well it's too late for v4.7 due to intrusiveness, so please refine the series and
also incorporate the cleanups requested by Boris. I can put it into -tip whenever
you guys submit it, but it will have to wait for v4.8 most likely.

Thanks,

Ingo

\
 
 \ /
  Last update: 2016-05-11 17:41    [W:0.073 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site