lkml.org 
[lkml]   [2016]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 5/5] dax: fix a comment in dax_zero_page_range and dax_truncate_page
    Date
    The distinction between PAGE_SIZE and PAGE_CACHE_SIZE was removed in

    09cbfea mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release}
    macros

    The comments for the above functions described a distinction between
    those, that is now redundant, so remove those paragraphs

    Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
    ---
    fs/dax.c | 12 ------------
    1 file changed, 12 deletions(-)

    diff --git a/fs/dax.c b/fs/dax.c
    index 0167cde..afa289c 100644
    --- a/fs/dax.c
    +++ b/fs/dax.c
    @@ -1221,12 +1221,6 @@ static bool dax_range_is_aligned(struct block_device *bdev,
    * page in a DAX file. This is intended for hole-punch operations. If
    * you are truncating a file, the helper function dax_truncate_page() may be
    * more convenient.
    - *
    - * We work in terms of PAGE_SIZE here for commonality with
    - * block_truncate_page(), but we could go down to PAGE_SIZE if the filesystem
    - * took care of disposing of the unnecessary blocks. Even if the filesystem
    - * block size is smaller than PAGE_SIZE, we have to zero the rest of the page
    - * since the file might be mmapped.
    */
    int dax_zero_page_range(struct inode *inode, loff_t from, unsigned length,
    get_block_t get_block)
    @@ -1278,12 +1272,6 @@ EXPORT_SYMBOL_GPL(dax_zero_page_range);
    *
    * Similar to block_truncate_page(), this function can be called by a
    * filesystem when it is truncating a DAX file to handle the partial page.
    - *
    - * We work in terms of PAGE_SIZE here for commonality with
    - * block_truncate_page(), but we could go down to PAGE_SIZE if the filesystem
    - * took care of disposing of the unnecessary blocks. Even if the filesystem
    - * block size is smaller than PAGE_SIZE, we have to zero the rest of the page
    - * since the file might be mmapped.
    */
    int dax_truncate_page(struct inode *inode, loff_t from, get_block_t get_block)
    {
    --
    2.5.5
    \
     
     \ /
      Last update: 2016-05-10 21:21    [W:2.631 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site