Messages in this thread | | | Date | Tue, 10 May 2016 15:39:49 +0800 | From | William Wu <> | Subject | Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip |
| |
Dear Felipe & Doug, Thanks for your proposal. It's a good idea to sort the list. I'll fix it next patch version.
On 05/10/2016 03:14 PM, Felipe Balbi wrote: > Hi, > > Doug Anderson <dianders@google.com> writes: >> William, >> >> On Mon, May 9, 2016 at 4:46 AM, William Wu <william.wu@rock-chips.com> wrote: >>> Signed-off-by: William Wu <william.wu@rock-chips.com> >>> --- >>> drivers/usb/dwc3/dwc3-of-simple.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c >>> index 9743353..1f3665b 100644 >>> --- a/drivers/usb/dwc3/dwc3-of-simple.c >>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c >>> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = { >>> static const struct of_device_id of_dwc3_simple_match[] = { >>> { .compatible = "qcom,dwc3" }, >>> { .compatible = "xlnx,zynqmp-dwc3" }, >>> + { .compatible = "rockchip,dwc3" }, >> It is, of course, up to Felipe. ...but personally I'd prefer that >> things here be sorted alphabetically. Sorting things in a consistent >> manner tends to reduce merge conflicts as the list gets longer and >> also makes it easier to find things. > I agree, let's keep it sorted :-) >
| |