Messages in this thread | | | Date | Sun, 01 May 2016 09:28:04 +0300 | From | Eli Billauer <> | Subject | Re: [PATCH v2] char: xillybus: use devm_add_action_or_reset |
| |
Fine with me. Thanks.
Acked-by: Eli Billauer <eli.billauer@gmail.com>
On 30/04/16 19:13, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling dma_unmap_single(), > pci_unmap_single() and kfree(). Lets use the helper > devm_add_action_or_reset() and return directly in case of error, as we > know that the cleanup function has been already called by the helper if > there was any error. At that same time remove the variable rc which > becomes unused now. > > Signed-off-by: Sudip Mukherjee<sudip.mukherjee@codethink.co.uk> > --- > >
| |