lkml.org 
[lkml]   [2016]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/2] usb: musb: pic32: Add USB DRC driver for PIC32 OTG controller.
Date

Hi,

Purna Chandra Mandal <purna.mandal@microchip.com> writes:
>> Purna Chandra Mandal <purna.mandal@microchip.com> writes:
>>> From: Cristian Birsan <cristian.birsan@microchip.com>
>>>
>>> This driver adds support of PIC32 MUSB OTG controller as
>>> dual role device. It implements platform specific glue to
>>> reuse musb core.
>>>
>>> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
>>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
>>>
>>> In-reply-to: 460027775-20729-2-git-send-email-purna.mandal@microchip.com
>>>
>>> ---
>>>
>>> Changes in v2:
>>> - fix i386 build
>>> - fix indentation
>>>
>>> drivers/usb/musb/Kconfig | 9 +-
>>> drivers/usb/musb/Makefile | 1 +
>>> drivers/usb/musb/pic32.c | 608 ++++++++++++++++++++++++++++++++++++++++++++++
>>> 3 files changed, 617 insertions(+), 1 deletion(-)
>>> create mode 100644 drivers/usb/musb/pic32.c
>>>
>>> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
>>> index 886526b..1970c1e 100644
>>> --- a/drivers/usb/musb/Kconfig
>>> +++ b/drivers/usb/musb/Kconfig
>>> @@ -112,6 +112,13 @@ config USB_MUSB_BLACKFIN
>>> depends on (BF54x && !BF544) || (BF52x && ! BF522 && !BF523)
>>> depends on NOP_USB_XCEIV
>>>
>>> +config USB_MUSB_PIC32
>>> + tristate "Microchip PIC32 USB platforms"
>>> + depends on MACH_PIC32
>> no, we like to build stuff on other arches, this should be:
>>
>> depends on MACH_PIC32 || COMPILE_TEST
>>
>> and you should *really* fix the build error, not work around it.
>
> This driver is for PIC32MZDA platforms which are powered by MIPS 14Kec CPU.
>
> The offending API 'readsl()' is implemented by MIPS arch (in
> arch/mips/include/asm/io.h), but not by i386 arch.

odd, asm-generic/io.h has an implementation. In any case, why couldn't
you use readl() instead ?

> IMO compiling for i386 is not required.

it is for build coverage.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-04-08 08:01    [W:0.051 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site