lkml.org 
[lkml]   [2016]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: android: ion: dummy: fix dereference of ERR_PTR
From
Date
On 04/07/2016 09:32 AM, Sudip Mukherjee wrote:
> ion_device_create() can fail and if it fails then it returns the error
> value in ERR_PTR.
>

Reviewed-by: Laura Abbott <labbott@redhat.com>

> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> drivers/staging/android/ion/ion_dummy_driver.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b/drivers/staging/android/ion/ion_dummy_driver.c
> index 5678870..806e76b 100644
> --- a/drivers/staging/android/ion/ion_dummy_driver.c
> +++ b/drivers/staging/android/ion/ion_dummy_driver.c
> @@ -68,6 +68,8 @@ static int __init ion_dummy_init(void)
> int i, err;
>
> idev = ion_device_create(NULL);
> + if (IS_ERR(idev))
> + return PTR_ERR(idev);
> heaps = kcalloc(dummy_ion_pdata.nr, sizeof(struct ion_heap *),
> GFP_KERNEL);
> if (!heaps)
>

\
 
 \ /
  Last update: 2016-04-08 00:21    [W:0.042 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site