Messages in this thread | | | Subject | Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. | From | Joe Perches <> | Date | Thu, 07 Apr 2016 13:21:58 -0700 |
| |
On Thu, 2016-04-07 at 20:43 +0100, David Howells wrote: > Joe Perches <joe@perches.com> wrote: > > > Joe Perches <joe@perches.com> wrote: > > > > It might be better to remove kenter and _enter > > > > altogether and use function tracing instead. > > > Possibly - but not at this time. > > Swell. > I didn't say I wouldn't do it - it's just that I'm trying to fix other stuff > at the moment and don't particularly want to add that to the list just now. > kenter, _enter and co. are serving me very well.
No worries, I didn't mean to imply you wouldn't. It's your code, do what and when you want.
> > > Besides, isn't the function tracing log lost > > > if the machine crashes? > > I believe yes, but would it matter? > Let's see... If the machine panics whilst I'm developing stuff (quite likely > if something goes wrong in BH context), how do I get at the function tracing > log to find out why it panicked if the log is then lost? With the serial > console, at least I automatically capture the output of kenter and co..
But you also don't get a bunch of other useful stuff.
btw: there is ftrace_dump_on_oops
https://lwn.net/Articles/366796/
| |