lkml.org 
[lkml]   [2016]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] lkdtm: fix memory leak of val
From
On Tue, Apr 5, 2016 at 10:11 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> This case is supposed to read from a page after after it is freed, but
> it missed freeing val if we are not able to get a free page.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> drivers/misc/lkdtm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
> index 5f1a36b..2f0b022 100644
> --- a/drivers/misc/lkdtm.c
> +++ b/drivers/misc/lkdtm.c
> @@ -498,12 +498,13 @@ static void lkdtm_do_action(enum ctype which)
> }
> case CT_READ_BUDDY_AFTER_FREE: {
> unsigned long p = __get_free_page(GFP_KERNEL);
> - int saw, *val = kmalloc(1024, GFP_KERNEL);
> + int saw, *val;
> int *base;
>
> if (!p)
> break;
>
> + val = kmalloc(1024, GFP_KERNEL);

There's actually still a leak of "p" here, but I've fix that now too. Thanks!

-Kees

> if (!val)
> break;
>
> --
> 1.9.1
>



--
Kees Cook
Chrome OS & Brillo Security

\
 
 \ /
  Last update: 2016-04-07 01:01    [W:0.060 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site