lkml.org 
[lkml]   [2016]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] char: xillybus: use devm_add_action_or_reset
On Tue, Apr 26, 2016 at 01:23:08PM +0300, Eli Billauer wrote:
> Thanks,
>
> I like the direction, however both xilly_map_single_* functions turn
> out ending with
>
> if (rc)
> return rc;
>
> return 0;
>
> Which is equivalent to just "return rc". Or maybe return the value
> of the devm_add_action_or_reset() call directly, and remove the "rc"
> variable? I don't know which one is better coding style.

ofcourse, it was very silly of me not to notice that.
v2 sent for your consideration.

regards
sudip

\
 
 \ /
  Last update: 2016-04-30 18:41    [W:0.057 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site