Messages in this thread | | | Date | Sat, 30 Apr 2016 17:14:41 +0100 | From | Sudip Mukherjee <> | Subject | Re: [PATCH] char: xillybus: use devm_add_action_or_reset |
| |
On Tue, Apr 26, 2016 at 01:23:08PM +0300, Eli Billauer wrote: > Thanks, > > I like the direction, however both xilly_map_single_* functions turn > out ending with > > if (rc) > return rc; > > return 0; > > Which is equivalent to just "return rc". Or maybe return the value > of the devm_add_action_or_reset() call directly, and remove the "rc" > variable? I don't know which one is better coding style.
ofcourse, it was very silly of me not to notice that. v2 sent for your consideration.
regards sudip
| |