lkml.org 
[lkml]   [2016]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/7] drivers/mfd: make max14577.c explicitly non-modular
    Date
    The Kconfig currently controlling compilation of this code is:

    mfd/Kconfig:config MFD_MAX14577
    mfd/Kconfig: bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support"

    ...meaning that it currently is not being built as a module by anyone.

    Lets remove the modular code that is essentially orphaned, so that
    when reading the driver there is no doubt it is builtin-only.

    Since module_init was not in use by this code, the init ordering
    remains unchanged with this commit.

    Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

    We also delete the MODULE_LICENSE tag etc. since all that information
    is already contained at the top of the file in the comments.

    Cc: Chanwoo Choi <cw00.choi@samsung.com>
    Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    Cc: Samuel Ortiz <sameo@linux.intel.com>
    Cc: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/mfd/max14577.c | 13 +------------
    1 file changed, 1 insertion(+), 12 deletions(-)

    diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
    index 2280b3fdcf68..9c0eb4efe246 100644
    --- a/drivers/mfd/max14577.c
    +++ b/drivers/mfd/max14577.c
    @@ -19,7 +19,7 @@
    */

    #include <linux/err.h>
    -#include <linux/module.h>
    +#include <linux/init.h>
    #include <linux/interrupt.h>
    #include <linux/of_device.h>
    #include <linux/mfd/core.h>
    @@ -490,7 +490,6 @@ static const struct i2c_device_id max14577_i2c_id[] = {
    { "max77836", MAXIM_DEVICE_TYPE_MAX77836, },
    { }
    };
    -MODULE_DEVICE_TABLE(i2c, max14577_i2c_id);

    #ifdef CONFIG_PM_SLEEP
    static int max14577_suspend(struct device *dev)
    @@ -562,13 +561,3 @@ static int __init max14577_i2c_init(void)
    return i2c_add_driver(&max14577_i2c_driver);
    }
    subsys_initcall(max14577_i2c_init);
    -
    -static void __exit max14577_i2c_exit(void)
    -{
    - i2c_del_driver(&max14577_i2c_driver);
    -}
    -module_exit(max14577_i2c_exit);
    -
    -MODULE_AUTHOR("Chanwoo Choi <cw00.choi@samsung.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com>");
    -MODULE_DESCRIPTION("Maxim 14577/77836 multi-function core driver");
    -MODULE_LICENSE("GPL");
    --
    2.8.0
    \
     
     \ /
      Last update: 2016-04-03 23:41    [W:4.068 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site