Messages in this thread | | | Subject | Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks | From | Neil Armstrong <> | Date | Sun, 3 Apr 2016 15:56:26 +0200 |
| |
On 04/02/2016 02:50 AM, Stephen Boyd wrote: > On 04/01, Neil Armstrong wrote: >> + if (!onecell_data) >> + return -ENOMEM; >> + >> + regmap = syscon_node_to_regmap(of_get_parent(np)); > > Can we use dev_get_regmap(&pdev->dev.parent) here instead? I'd > prefer device APIs over DT APIs here. >
It will not work here since the parent node is a syscon, the call to syscon_node_to_regmap() will call of_syscon_register() and create the regmap, the dev_get_regmap() needs a proper platform device registered as regmap here.
Neil
| |