Messages in this thread | | | Date | Fri, 29 Apr 2016 08:43:43 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v4] x86/boot: Warn on future overlapping memcpy() use |
| |
* Kees Cook <keescook@chromium.org> wrote:
> If an overlapping memcpy() is ever attempted, we should at least report > it, in case it might lead to problems, so it could be changed to a > memmove() call instead. > > Suggested-by: Ingo Molnar <mingo@kernel.org> > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > v4: > - use __memcpy not memcpy since we've already done the check. > v3: > - call memmove in addition to doing the warning > v2: > - warn about overlapping region > --- > arch/x86/boot/compressed/string.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-)
Applied, thanks Kees!
Btw., can we now also remove the memmove() hack from lib/decompress_unxz.c?
Thanks,
Ingo
| |